refactor(rir): replace Vec fields with extra array pattern #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
force-pushed
the
steveklabnik/push-smsllxqqozty
branch
6 times, most recently
from
4f8684b to
ea17241
Compare
Convert all InstData variants that embedded Vec<T> to use the extra array pattern (start: u32, len: u32). This follows the Zig ZIR approach. Affected variants: - Match: arms now in extra array - FnDecl: directives and params now in extra array - Call, MethodCall, AssocFnCall, Intrinsic: args now in extra array - ArrayInit: elements now in extra array - StructInit, StructDecl: fields now in extra array - EnumDecl: variants now in extra array - ImplDecl: methods now in extra array - Alloc: directives now in extra array Benefits: - Reduces InstData enum size from ~64+ bytes to ~24 bytes - Eliminates per-instruction heap allocations - Improves cache locality during IR traversal Fix: Use try_from_usize instead of non-existent from_usize_unchecked in Symbol::from_raw. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
steveklabnik
force-pushed
the
steveklabnik/push-smsllxqqozty
branch
from
ea17241 to
0c37081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all InstData variants that embedded Vec to use the extra array pattern (start: u32, len: u32). This follows the Zig ZIR approach.
Affected variants:
Benefits:
🤖 Generated with Claude Code